Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tizen spec: fix path macros #2903

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

myungjoo
Copy link
Member

Path macro has been incorrectly used.

%{_libdir} == /usr/lib, /usr/lib64, or ...
%{_bindir} == /usr/bin

Meson accepts postfixes for libdir and bindir.
Do not give meson absolute pathes for libdir/bindir. The relative library path working as postfix is %{_lib}.

Standard rpm macros are at:
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/

Copy link

@haehun haehun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Path macro has been incorrectly used.

%{_libdir} == /usr/lib, /usr/lib64, or ...
%{_bindir} == /usr/bin

Meson accepts postfixes for libdir and bindir.
Do not give meson absolute pathes for libdir/bindir.
The relative library path working as postfix is %{_lib}.

Standard rpm macros are at:
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/

Signed-off-by: MyungJoo Ham <[email protected]>
@myungjoo myungjoo merged commit 9ce6628 into nnstreamer:main Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants