Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix memory leakage issue in inference mode @open sesame 02/10 19:43 #2933

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

baek2sm
Copy link
Contributor

@baek2sm baek2sm commented Feb 10, 2025

this patch fix a memory leakage issue in inference mode.

The problem occurred because even though deallocation was performed,
vectors inside the memory pool were still remained.

Self evaluation:

Build test: [x]Passed [ ]Failed [ ]Skipped
Run test: [x]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong [email protected]

this patch fix a memory leakage issue in inference mode.

The problem occurred because even though deallocation was performed,
vectors inside the memory pool were still remained.

**Self evaluation:**

Build test: [x]Passed [ ]Failed [ ]Skipped
Run test: [x]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong <[email protected]>
@baek2sm baek2sm changed the title [Bug] fix memory leakage problem in inference mode [Bug] fix memory leakage issue in inference mode Feb 10, 2025
@baek2sm baek2sm changed the title [Bug] fix memory leakage issue in inference mode [Bug] fix memory leakage issue in inference mode @open sesame 02/10 19:41 Feb 10, 2025
@baek2sm baek2sm changed the title [Bug] fix memory leakage issue in inference mode @open sesame 02/10 19:41 [Bug] fix memory leakage issue in inference mode @open sesame 02/10 19:43 Feb 10, 2025
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch

Copy link

@haehun haehun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

@jijoongmoon jijoongmoon merged commit 37b1d2c into nnstreamer:main Feb 11, 2025
23 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants