Fix saving and resetting queued groups #176
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Lexer.prototype.reset
andLexer.prototype.save
reference threequeued
fields:queuedToken
,queuedText
(added in #169) andqueuedThrow
.There only appear to be references to
queuedText
andqueuedGroup
elsewhere, so this MR removesqueuedToken
andqueuedThrow
and addsqueuedGroup
toreset
andsave
.The below example shows how this could be problematic - on master it prints a token when it probably shouldn't: