Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unicode flag where missing #181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

loveencounterflow
Copy link

I realized that the below regex will be rejected with Invalid regular expression: [...] Range out of order in character class when using it in moo.compile() (Note: using extended syntax with extra whitespace for readability):

/// [        A-Z _ a-z \u{00a1}-\u{10ffff}  ] [  $ 0-9 A-Z _ a-z \u{00a1}-\u{10ffff}  ]* ///u

This can be fixed by using the u flag on lines 25 and 263. Of course, this is something of a hotfix because that would presumably turn all regexes into Unicode regexes (maybe a Good Thing?); therefore, I leave it to those with better acquaintance with the codebase to come up with a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant