Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the below regex will be rejected with
Invalid regular expression: [...] Range out of order in character class
when using it inmoo.compile()
(Note: using extended syntax with extra whitespace for readability):/// [ A-Z _ a-z \u{00a1}-\u{10ffff} ] [ $ 0-9 A-Z _ a-z \u{00a1}-\u{10ffff} ]* ///u
This can be fixed by using the
u
flag on lines 25 and 263. Of course, this is something of a hotfix because that would presumably turn all regexes into Unicode regexes (maybe a Good Thing?); therefore, I leave it to those with better acquaintance with the codebase to come up with a proper solution.