-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/icap mme #166
Merged
Merged
Feature/icap mme #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds the ICAP_MME results to MONETIO. ICAP_MME is a 9 model ensemble from multiple operational data sources for aerosols. It is available through https://usgodae.org/metools/ensemble/
zmoon
reviewed
Mar 21, 2024
zmoon
reviewed
Mar 22, 2024
zmoon
reviewed
Mar 22, 2024
Co-authored-by: Zachary Moon <[email protected]>
May have to make it a "core" dep...
seems to work fine without `verify=False`
@zmoon this works great on my end |
zmoon
reviewed
Mar 22, 2024
bbakernoaa
commented
Mar 22, 2024
zmoon
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbakernoaa I'm pretty happy with this unless you have more test ideas or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds on top of #132 adding the ICAP_MME to monetio. ICAP MME is the 9 member multi member ensemble system developed at NRL. It is available through https://usgodae.org/metools/ensemble/