Fix bugs in layer height and temperature #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoon
reviewed
Sep 11, 2024
|
The recent commit displeased the formatter |
|
@zmoon Just run pre-commit and black found some issues. Should be fixed now. |
zmoon
approved these changes
Sep 11, 2024
|
I just saw that the docs failed. I don't think I modified anything in them? |
|
It was in the link check, CRN website currently down https://www.ncei.noaa.gov/access/crn/ |
|
https://www.ncei.noaa.gov/ is back now, but data stuff still out (giving 404) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the fixes for the bug I mentioned.
I am sorry for having to reopen a pull request about this!
In short:
the previous code only worked if CAMX had NETCDF input files, which is not always the case, and had a typo at calling for dset_variables. It was also not adding the temperature.
I also changed the name of layer height to make it more clear.
Cheers
Pablo