Fix cor in plot (#141)

* update the corr value when denominator is zero * format surrogate.py with oitnb
noaa-ocs-modeling · Apr 11, 2024 · 71804ad · 71804ad
1 parent 6b235c3
commit 71804ad
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ensembleperturbation/plotting/surrogate.py b/ensembleperturbation/plotting/surrogate.py
@@ -26,8 +26,10 @@ def corrcoef(O, P):
         OD2 = ((O - MO) ** 2).sum()
         PDOD = ((P - MP) * (O - MO)).sum()
         corr = PDOD / (PD2 * OD2) ** 0.5
-        if numpy.isnan(corr.values):
+        if (PDOD == 0) & (PD2 == 0) & (OD2 == 0):
             corr.values = 1.0  # 0/0: perfect correlation
+        elif (PD2 == 0) or (OD2 == 0):
+            corr.values = 0.0  # No./0: no-correlation
         return corr
 
     # correlation coefficient