Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable isotach perturbation is GAHM RMW perturbation is not selected #162

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Disable isotach perturbation is GAHM RMW perturbation is not selected #162

merged 5 commits into from
Oct 7, 2024

Conversation

SorooshMani-NOAA
Copy link
Collaborator

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Oct 4, 2024
WPringle
WPringle approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition and coding layout changes!
It looks like the other test results are unchanged, so it must be working as expected.

@WPringle
Copy link
Contributor

WPringle commented Oct 7, 2024 •
edited
Loading

To be clear, the use case is the following, correct?:

  1. no isotach adjustment:
features=None
 or 
features=PerturberFeatures.NONE
  1. with isotach adjustment [default]
features=PerturberFeatures.ISOTACH_ADJUSTMENT

@SorooshMani-NOAA
Copy link
Collaborator Author

@WPringle yes that's what I had in mind for how to use it.

@SorooshMani-NOAA
Copy link
Collaborator Author

Given https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/618#issuecomment-2397760722, do you want me to wait for your changes before merging?

@WPringle
Copy link
Contributor

WPringle commented Oct 7, 2024

@SorooshMani-NOAA No, I think this is fine to merge, and then can make a different PR with that change..

@SorooshMani-NOAA SorooshMani-NOAA merged commit 17a2280 into main Oct 7, 2024
8 of 10 checks passed
@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/persistent_noisotach branch October 7, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WPringle WPringle WPringle approved these changes

Assignees

@SorooshMani-NOAA SorooshMani-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SorooshMani-NOAA @WPringle