Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDVX data, add flags for some filtering options, add filter by date option #260

Merged
merged 16 commits into from
Apr 25, 2024
Merged

Conversation

kbh-exe
Copy link
Contributor

@kbh-exe kbh-exe commented Dec 4, 2023

Added more music id exclusions and added distribution_date to be returned for calendar date exclusion, fixed typo with comment for exclusion

Added more music id exclusions and added distribution_date to be returned for calendar date exclusion
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ddr-tools ✅ Ready (Inspect) Visit Preview Apr 25, 2024 6:04am

Copy link
Owner

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good! I think there's a reasonable use case for compiling and using a date_added field for a lot of other games besides SDVX too

scripts/import-sdvx.mjs Outdated Show resolved Hide resolved
@kbh-exe
Copy link
Contributor Author

kbh-exe commented Apr 12, 2024

Adding flags regarding Blaster Gate/Omega Dimension, Hexadiver, Time Limited/Arena, and Region Exclusive based on the song ID labels based on text file attached.
SDVX Unlock Music IDs.txt

@noahm noahm changed the title Update import-sdvx.mjs Update SDVX data, add flags for some filtering options, add filter by date option Apr 21, 2024
@kbh-exe
Copy link
Contributor Author

kbh-exe commented Apr 22, 2024

Not quite sure why, but only songID 2027 in the import-sdvx script now seems to not be correctly implementing the jpOnly flag.

@noahm
Copy link
Owner

noahm commented Apr 25, 2024

Not quite sure why, but only songID 2027 in the import-sdvx script now seems to not be correctly implementing the jpOnly flag.

My first "fix applying flags to songs" change worked but had accidentally omitted the first 10 IDs in each of the sections within unlocks.mjs. That's corrected now and all flags are correctly being applied in the imported data.

@noahm noahm merged commit 131efdf into noahm:main Apr 25, 2024
5 checks passed
@noahm
Copy link
Owner

noahm commented Apr 25, 2024

Thank you for patiently working through this all with me, by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants