Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortLevel feature added into configState #280

Merged
merged 3 commits into from
Dec 30, 2023

Conversation

paulitup
Copy link

@paulitup paulitup commented Dec 25, 2023

Added a checkbox within General Settings to sort charts by difficulty level.

Fixes #269

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ddr-tools ✅ Ready (Inspect) Visit Preview Dec 28, 2023 2:34am

Copy link
Owner

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Everything here is exactly as I would do it, save for one specific detail. In this case sorting should not be a matter of display logic, but of the draw procedure itself.

src/drawn-set.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit to fix and this is ready to merge!

src/card-draw.ts Outdated Show resolved Hide resolved
@noahm noahm enabled auto-merge December 30, 2023 22:31
@noahm noahm merged commit 6ddfacf into noahm:main Dec 30, 2023
2 checks passed
@paulitup paulitup deleted the feature/SortLevel branch January 6, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to have cards in a draw sorted by difficulty
2 participants