Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IIDX AC support using textage.cc as source #286

Merged
merged 25 commits into from
Jan 3, 2024

Conversation

telperion
Copy link
Contributor

@telperion telperion commented Jan 3, 2024

Pretty much what it says on the label!
image
I'm gonna use it for a tourney I'm running in February.

Highlights

  • By importing textage.cc's JavaScript files (which contain huge tables of data about chart levels and metadata) and creating a local JSDOM, we can comfortably run queries without phoning home for every request.
  • IIDX tends not to give songs unique art, so I've included a system to generate SVG files that serve as "jackets", tied to each song's version of origin by accent colors in that version's theme. (I could probably place the mix name somewhere in there, too? Maybe later)
  • Songs locked behind events such as WORLD TOURISM and X-record are also labeled with flags.
    image

A minor app-wide tweak

  • Support for per-chart BPM: A handful of IIDX songs have significantly different BPM maps depending on which chart is being played. For example, crew (whose SPH, SPA, DPH, and DPA charts play various arrangements of the base song found in the SPN/DPN slots) might need to be listed as 150, 152, 155, 170, or 176 BPM!

Outstanding (lower-priority) work

  • Title/artist transliterations. There are official ones (i.e. ticker text) and remywiki generally notes them, but where exactly on the page they're listed varies a lot. Also, players generally can identify songs in Japanese characters by version, difficulty, and BPM. (Cue the classic joke of posting a hard clear on 罠 [a] and having everyone yell "yoooooo nice Mei HC")
  • Theoretically we could add tiering based on community lists, but I don't wanna clutter the app in the first PR for this haha
  • Better scraping of time-based, arena, and shop unlocks. textage doesn't indicate these, so I'd have to co-ingest something like bemaniwiki to get that info.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ddr-tools ✅ Ready (Inspect) Visit Preview Jan 3, 2024 7:44pm

Copy link
Owner

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly excellent work! Nothing really blocking here, so I'll leave it to you whether you want to make more changes before merging.

On the subject of transliterations/translations, you could maybe cheat a bit and copy over any exact matches for song titles in the existing DDR or SDVX files? That would at least cover your classic case of A vs Mei 😅

scripts/scraping/textage.mjs Show resolved Hide resolved
scripts/import-iidx.mjs Show resolved Hide resolved
@@ -0,0 +1,39 @@
<?xml version="1.0"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually just a test? maybe delete?

@@ -0,0 +1,39 @@
<?xml version="1.0"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this template file should probably live in the scripts folder next to the iidx import script that uses it


var data = {
meta: {
menuParent: "more",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only games I've related to the more folder are older mixes and/or rarely used. I'd be fine having this at the top level 😁

- forgot about arena/secret legs and one-off unlocks...fixed now tho
@telperion
Copy link
Contributor Author

I forgot about some time-locked charts and songs, so I added a few things for that just now - but otherwise I think we should be set!

I'll ponder translations/transliterations and more automatic unlock scraping for another PR haha

@noahm noahm merged commit a368f24 into noahm:main Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants