-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IIDX AC support using textage.cc as source #286
Conversation
- 12L -> 12, 12M -> 13, 12H -> 14
- and refresh the listing, which changes the data table
- creates SVG jacket for each version folder - better handling of titles/subtitles with HTML entities or tags - per-chart BPMs now part of schema and utilized by IIDX song database
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly excellent work! Nothing really blocking here, so I'll leave it to you whether you want to make more changes before merging.
On the subject of transliterations/translations, you could maybe cheat a bit and copy over any exact matches for song titles in the existing DDR or SDVX files? That would at least cover your classic case of A vs Mei 😅
src/assets/jackets/iidx/test.svg
Outdated
@@ -0,0 +1,39 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this actually just a test? maybe delete?
@@ -0,0 +1,39 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this template file should probably live in the scripts folder next to the iidx import script that uses it
scripts/import-iidx.mjs
Outdated
|
||
var data = { | ||
meta: { | ||
menuParent: "more", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only games I've related to the more folder are older mixes and/or rarely used. I'd be fine having this at the top level 😁
- forgot about arena/secret legs and one-off unlocks...fixed now tho
I forgot about some time-locked charts and songs, so I added a few things for that just now - but otherwise I think we should be set! I'll ponder translations/transliterations and more automatic unlock scraping for another PR haha |
Pretty much what it says on the label!
I'm gonna use it for a tourney I'm running in February.
Highlights
A minor app-wide tweak
Outstanding (lower-priority) work