Added option to swap pane position (put edit pane above output) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the option is on, then vertical layout has code on top, output on bottom, and horizontal has code on left, output on right. Also, with code on top, changed notebook tabs to be on top too.
When panes are swapped (edit on top), the autocomplete popup now stretches DOWN from the cursor, not up. This makes it so it won't extend up off the screen.
Previous fix caused the autocomplete box to overlap the cursor. We adjust its position by lineheight to avoid this.
The problem seems to be due to the _n_unclaimed_results counter somehow getting out of sync. At some point, this counter is incremeneted but not properly decremented. The result is that DreamPie keeps saying "subprocess is busy", thinking it is waiting for a result, but there really isn't any result coming, so it waits forever. (This waiting occurs in DreamPie.call_subp_noblock, which is called from execute_source.) The "solution" is to add a simple method to the DreamPie class that just decrements _n_unclaimed_results. I then added a menu item to call this function. If this "stuck" situation arises, you can clear it by using this manual override. Note that using this when the subprocess is *not* stuck could cause havoc, so be careful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the option is on, then vertical layout has code on top, output on bottom,
and horizontal has code on left, output on right.
Also, with code on top, changed notebook tabs to be on top too.