Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Queue/Trigger the replay using sloctl [PC-13394] #237

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dawidwisn
Copy link
Contributor

Motivation

We're adding a new way to create a Replay. The new Replay is added to the queue and there's no need to wait for the reimport to complete.

Related changes

A new way of creating a Replay. The new Replays are queued.

internal/replay.go Outdated Show resolved Hide resolved
@paulina-n9
Copy link
Contributor

I’ve tested all possible scenarios with both the old and new versions of sloctl, with playlists enabled and disabled.
I also verified both methods of running replay - using the config file and using the sloctl replay -p <slo> command for a single SLO.
Backward compatibility is maintained for the old version of sloctl (tested with 0.5.2).
Here’s a sample of how it looks with sloctl built from the branch with playlists enabled:

Zrzut ekranu 2024-10-31 o 14 46 47

Zrzut ekranu 2024-10-31 o 14 56 19

@paulina-n9 paulina-n9 added the passed-testing Added by QA when tests have passed label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore go passed-testing Added by QA when tests have passed patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants