-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add add_analyzer functionality #3
base: ros2
Are you sure you want to change the base?
Conversation
|
||
private: | ||
rclcpp::Client<rcl_interfaces::srv::SetParametersAtomically>::SharedPtr client_; | ||
std::string prefix_ = "analyzers."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps a little more clarity could help with the name. Something like a node_param_ns_
,?
Great, please fix the linting (See CI) and rebase of the |
7ca53cd
to
8c85be7
Compare
8c85be7
to
863d110
Compare
817e6f6
to
f3b4b35
Compare
f3b4b35
to
d8c28eb
Compare
…:nobleo/diagnostics into feature/add-analyzers-through-parameters
… service namespace from diagnostics_agg to analyzers
/********************************************************************* | ||
* Software License Agreement (BSD License) | ||
* | ||
* Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you write this code or adapted this from somewhere? If you wrote it yourself, this should be the BV where you work for, so Copyright 2024 Nobleo Autonomous Solutions B.V.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrote it myself but just copied the pasta for the notice and forgot to make it Nobleo Technology or whatever it should be, will update.
* copyright notice, this list of conditions and the following | ||
* disclaimer in the documentation and/or other materials provided | ||
* with the distribution. | ||
* * Neither the name of the Willow Garage nor the names of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the standard BSD sentences:
3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change it? Now the license matches all the other files in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeh I see what you mean now it can't stay willow garage :P
…ger, remove unnecessary hardcoded namespace from yaml files
…fter copying the notice
Applied the following changes:
Move the creation of
analyzer_group_
andother_analyzer_
from the constructor to a new functioninitAnalyzers()
.Added a subscriber to parameter events
param_sub_
that triggers a callbackparameterCallback
.Check in the callback if
this
node got any new paramters -> if true, lock the mutex and callinitAnalyzers()
again.Created an
add_analyzer
node that forwards its own parameters to thediagnostic_aggregator
by sending a request to/diagnostics_agg/set_parameters_atomically
serviceThe
add_analyzer
looks for all parameters starting with the prefixanalyzers.
, converts them to a parameter_msg and sends them together as oneSetParametersAtomically::Request
Example usage: