Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages.py #2

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Update messages.py #2

merged 1 commit into from
Aug 11, 2023

Conversation

wsneijers
Copy link
Contributor

I noticed the wrong string was used when using the to_dmsg function in the Display class.

Wrong encoding string was used when encoding utf16le in dmsg message.
@nocarryr
Copy link
Owner

Good catch! I suppose I should add a test for that code path.

The ci tests are failing for unrelated reasons. I'll investigate to be sure then merge. Thanks!

@nocarryr nocarryr merged commit 106b416 into nocarryr:main Aug 11, 2023
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants