Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer-rocm/rocDecode: packages #60

Merged
merged 31 commits into from
Oct 28, 2024
Merged

packer-rocm/rocDecode: packages #60

merged 31 commits into from
Oct 28, 2024

Conversation

joshlay2amd
Copy link
Collaborator

@joshlay2amd joshlay2amd commented Oct 25, 2024

Inspiration: ROCm/rocDecode@8591037

Extending the packages handled by the ROCm play while reducing those in user-data. Surprisingly, this helps iteration speed. cloud-init processes in series while Ansible can process lists of packages at once.

Other process improvements:

  • The 'requirement' installation task is now delayed after repository setup. Allows the ROCm/amdgpu repositories to provide any of them, instead of just the Linux distribution.
  • Package downgrades are permitted for requests with the 'extra' and 'amdgpu' packages

The very-specific path has been tested. Need to ensure defaults still behave as expected.

@joshlay2amd
Copy link
Collaborator Author

Commits 6f68a23 and beyond include a refactor from the rocm play to an amdgpu_install role.

This attempts to do the installation for selected components with the scripted method.

Choosing a specific build seemed ineffective, landing on latest despite a specific build provided. I believe simply mishandled changing the build declarations from two keys in a dictionary (amdgpu_install_repos) to independent strings.

More to follow.

@joshlay2amd
Copy link
Collaborator Author

joshlay2amd commented Oct 26, 2024

A combination of issues - asking for versioned packages that should be handled by amdgpu-install (d5199ff)... and not passing the build numbers through correctly [as hinted in my last post - caad06b ]

Now able to build/deploy an image with very-specific release/builds and the internal package. Need to test the GA path next.

@joshlay2amd joshlay2amd marked this pull request as ready for review October 26, 2024 21:23
@joshlay2amd
Copy link
Collaborator Author

joshlay2amd commented Oct 26, 2024

Built an image with mostly-defaults, example:

ansible-playbook packer-rocm/playbooks/build.yml \
        -t build \
        -e hidden=false \
        -e rocm_builder_cpus=8 \
        -e rocm_builder_disk="40G"

Inspecting the archive, I found an oversight - the release/build defaults slipped. I intended 6.2.2 (for consistency with some testing)... but had put into motion changes for 6.2.3. Now consistent! Added MAINTENANCE.md as a warning 😄

Now can do both typical paths with amdgpu-install: given tag, given branch/internal packages. I believe this can be merged technically speaking. May benefit from well-rested review - typos and such are very likely.

@joshlay2amd joshlay2amd merged commit a71484b into main Oct 28, 2024
2 checks passed
@joshlay2amd joshlay2amd deleted the packer-rocm-newdeps branch October 28, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant