-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete iree_tests/sharktank/. #418
Conversation
@@ -77,15 +77,13 @@ jobs: | |||
run: | | |||
source ${VENV_DIR}/bin/activate | |||
python3 iree_tests/download_remote_files.py --root-dir iree_tests/pytorch/models | |||
python3 iree_tests/download_remote_files.py --root-dir iree_tests/sharktank | |||
|
|||
- name: "Running real weight model tests" | |||
if: "matrix.models-config-file != '' && !cancelled()" | |||
run: | | |||
source ${VENV_DIR}/bin/activate | |||
pytest \ | |||
iree_tests/pytorch/models \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can start porting these to https://github.com/iree-org/iree-test-suites as well. Just opt-125M and resnet50 in https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests/pytorch/models right now since no one helped port from e2eshark x_x, we wouldn't lose much by dropping that coverage without a replacement.
Cool, this makes sense. Are you going to be doing the follow up PR to remove this testing/updating pin in iree also? I actually don't think we even run any other SHARK-TestSuite tests in iree, so we can probably fully remove shark test suite from iree testing |
Yeah these run in IREE: https://github.com/iree-org/iree/blob/fb4d09470dc4be674de810dbfbf2d3764e2970ba/.github/workflows/pkgci_regression_test.yml#L83-L117. That
I don't mind dropping the two pytorch/models/ tests at the same time. The coverage provided there is small at the moment, and I'm reasonably close to having a replacement ready in iree-org/iree-test-suites#63. |
Makes sense, sgtm |
Fixes #17344. After nod-ai/SHARK-TestSuite#418, there are only two tests running in that test suite, both of which are XFAIL'd due to programs needing to be regenerated.
These tests are redundant with newer test suites here: