Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete iree_tests/sharktank/. #418

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

ScottTodd
Copy link
Member

These tests are redundant with newer test suites here:

@@ -77,15 +77,13 @@ jobs:
run: |
source ${VENV_DIR}/bin/activate
python3 iree_tests/download_remote_files.py --root-dir iree_tests/pytorch/models
python3 iree_tests/download_remote_files.py --root-dir iree_tests/sharktank

- name: "Running real weight model tests"
if: "matrix.models-config-file != '' && !cancelled()"
run: |
source ${VENV_DIR}/bin/activate
pytest \
iree_tests/pytorch/models \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can start porting these to https://github.com/iree-org/iree-test-suites as well. Just opt-125M and resnet50 in https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests/pytorch/models right now since no one helped port from e2eshark x_x, we wouldn't lose much by dropping that coverage without a replacement.

@saienduri
Copy link
Contributor

saienduri commented Dec 19, 2024

Cool, this makes sense. Are you going to be doing the follow up PR to remove this testing/updating pin in iree also? I actually don't think we even run any other SHARK-TestSuite tests in iree, so we can probably fully remove shark test suite from iree testing

@ScottTodd
Copy link
Member Author

Cool, this makes sense. Are you going to be doing the follow up PR to remove this testing/updating pin in iree also? I actually don't think we even run any other SHARK-TestSuite tests in iree, so we can probably fully remove shark test suite from iree testing

Yeah these run in IREE: https://github.com/iree-org/iree/blob/fb4d09470dc4be674de810dbfbf2d3764e2970ba/.github/workflows/pkgci_regression_test.yml#L83-L117. That test_models matrix.

          pytest \
            SHARK-TestSuite/iree_tests/pytorch/models \
            SHARK-TestSuite/iree_tests/sharktank \

I don't mind dropping the two pytorch/models/ tests at the same time. The coverage provided there is small at the moment, and I'm reasonably close to having a replacement ready in iree-org/iree-test-suites#63.

@saienduri
Copy link
Contributor

Makes sense, sgtm

@ScottTodd ScottTodd merged commit 7dd7501 into nod-ai:main Dec 19, 2024
2 checks passed
@ScottTodd ScottTodd deleted the iree-tests-cleanup-2 branch December 19, 2024 18:35
ScottTodd added a commit to iree-org/iree that referenced this pull request Jan 6, 2025
Fixes #17344.

After nod-ai/SHARK-TestSuite#418, there are only
two tests running in that test suite, both of which are XFAIL'd due to
programs needing to be regenerated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants