Add e2e and lit tests for ukernel+dcg mix #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix should get the example to work: Xilinx/mlir-air#656. |
|
Thanks @erwei-xilinx , the e2e matmul works with mixed ukernel and dcg now! |
yzhang93
reviewed
Jul 10, 2024
newling
force-pushed
the
ukernel_with_dcg
branch
from
17c673a to
0a21c52
Compare
newling
requested review from
MaheshRavishankar,
nirvedhmeshram,
Abhishek-Varma and
jtuyls
as code owners
yzhang93
requested changes
Jul 10, 2024
| return %matmul_add : tensor<?x?x?x?xbf16> | ||
| } | ||
| // CHECK: func @zero_fill_matmul_elmwise | ||
| // CHECK: iree_codegen.ukernel.generic "zero_bf16" |
There was a problem hiding this comment.
I would include // CHECK-NOT: linalg.fill
Comment on lines
252
to
254
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove these empty lines.
Comment on lines
330
to
335
| #The flag '--iree-amdaie-path-to-ukernels' currently does not work, | ||
| #see for example https: // github.com/nod-ai/iree-amd-aie/issues/340 | ||
| #Therefore we need to manually copy(or link) the mm.o file to the | ||
| #directory in which iree - compile is run.iree - compile is run in the | ||
| #output directory.Create the softlink only if it is has not already | ||
| #been created. |
There was a problem hiding this comment.
Nit: Please add/remove spaces for this comment.
Question: Will this issue be fixed next?
There was a problem hiding this comment.
I wasn't planning on looking at it next
newling
changed the title
yzhang93
reviewed
Jul 11, 2024
| compilation_flags="${compilation_flags} --iree-amdaie-enable-ukernels=all" | ||
|
|
||
| # The flag '--iree-amdaie-path-to-ukernels' currently does not work, | ||
| # see for example https://github.com/nod-ai/iree-amd-aie/issues/340 |
There was a problem hiding this comment.
Add a full stop at the end of this line.
| # The flag '--iree-amdaie-path-to-ukernels' currently does not work, | ||
| # see for example https://github.com/nod-ai/iree-amd-aie/issues/340 | ||
| # Therefore we need to manually copy (or link) the mm.o file to the | ||
| # directory in which iree - compile is run.iree - compile is run in the |
There was a problem hiding this comment.
Still see some format issue.
-> iree-comple is run. iree-compile ...
newling
force-pushed
the
ukernel_with_dcg
branch
from
a3def8d to
c7c5464
Compare
yzhang93
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test where we use a microkernel for a matmul, and directly generated code for a subsequent elementwise operation -- ie we mix ukernel with direct code generation.