Port zero-padding from mlir-aie #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/zero-padding
branch
3 times, most recently
from
fba7384 to
3d1c7c4
Compare
makslevental
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
|
Yeah the tests make sense to me. |
makslevental
force-pushed
the
makslevental/zero-padding
branch
from
3d1c7c4 to
a6e806b
Compare
jtuyls
reviewed
Jul 17, 2024
| before = static_cast<uint8_t>(padDims.value()[i].getConstPadBefore()); | ||
| after = static_cast<uint8_t>(padDims.value()[i].getConstPadAfter()); | ||
| } else { | ||
| before = static_cast<uint8_t>(padDims.value()[i].getConstPadBefore() * |
There was a problem hiding this comment.
Shouldn't we check that (padDims.value()[i].getConstPadBefore() * elementWidthIn32bWords) % 4 == 0 and fail otherwise? Otherwise, this could lead to hard to debug incorrect results.
There was a problem hiding this comment.
Edit: As discussed offline (padDims.value()[i].getConstPadBefore() * elementWidthIn32bWords) % 4 == 0 is incorrect. It should be bdOp.getBufferElementTypeWidthInBytes() * padDims.value()[i].getConstPadBefore() % 4 == 0
makslevental
force-pushed
the
makslevental/zero-padding
branch
from
1a4c050 to
cfa3c9d
Compare
makslevental
force-pushed
the
makslevental/zero-padding
branch
from
cfa3c9d to
67dcdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds zero-padding support to our CDO emission utility (port of Xilinx/mlir-aie#1613).
I trimmed the test cases down @erwei-xilinx can you give it a quick look to see if I didn't slip and miss something.
Fixes #537
cc @yzhang93 @MaheshRavishankar