Windows E2E #689
Windows E2E #689
Conversation
makslevental
force-pushed
the
makslevental/windows-e2e
branch
2 times, most recently
from
4f615fb to
eb62bc8
Compare
makslevental
requested review from
nirvedhmeshram,
newling,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
makslevental
force-pushed
the
makslevental/windows-e2e
branch
8 times, most recently
from
18065f0 to
a25f441
Compare
makslevental
force-pushed
the
makslevental/windows-e2e
branch
13 times, most recently
from
3b435af to
28fdae4
Compare
remove linux-phoenix-20240606
makslevental
force-pushed
the
makslevental/windows-e2e
branch
from
b62e325 to
a74fcde
Compare
makslevental
force-pushed
the
makslevental/windows-e2e
branch
2 times, most recently
from
c9c7175 to
1fdd989
Compare
makslevental
force-pushed
the
makslevental/windows-e2e
branch
from
1fdd989 to
cac317d
Compare
| - name: E2E correctness matmul test | ||
| run: | | ||
| source .venv/Scripts/activate | ||
| export XILINX_XRT=/c/Xilinx/XRT |
There was a problem hiding this comment.
On windows OS, all applications are supposed to uses xrt_coreutil.dll from c:\windows\system32. But this line make the CI computer use the xrt_coreutil.dll from /c/Xilinx/XRT.
This may cause all our tests get a different test result from a system deployed to general public
There was a problem hiding this comment.
Agree with Dezhi's statement. On Windows XILINX_XRT should not be set when running tests.
There was a problem hiding this comment.
On Windows XILINX_XRT should not be set when running tests.
As far as I am aware, XRT is open source and thus we are free to use it according to how it best suits our needs. So we have our usecase and implementation and you have yours. If you feel so strongly, you are free to refactor your code so that it doesn't expose these env variables (and I am free to fork).
Anyway XRT is deprecated in iree-amd-aie so this entire discussion is moot.
There was a problem hiding this comment.
@makslevental ,
What version of NPU KMD driver is installed on the windows computer used for CI?
There was a problem hiding this comment.
On Windows XILINX_XRT should not be set when running tests.
As far as I am aware, XRT is open source and thus we are free to use it according to how it best suits our needs. So we have our usecase and implementation and you have yours. If you feel so strongly, you are free to refactor your code so that it doesn't expose these env variables (and I am free to fork).
Anyway XRT is deprecated in
iree-amd-aieso this entire discussion is moot.
Based on what I see, removing XILINX_XRT works perfectly fine on my local system. There is a possible wrong setting on the CI computer
There was a problem hiding this comment.
Please stop commenting on this PR. It is now 3 months since it was closed. If you have some current issue then create a new issue about it.
This PR adds Windows E2E support.