Enable MacOS in CI #702
Merged
Enable MacOS in CI #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
makslevental
force-pushed
the
makslevental/macos
branch
9 times, most recently
from
69c8ca3 to
17ddb4c
Compare
makslevental
force-pushed
the
makslevental/macos
branch
2 times, most recently
from
894aa21 to
2e6916d
Compare
This reverts commit f88cbac.
makslevental
force-pushed
the
makslevental/macos
branch
from
2e6916d to
33d8381
Compare
newling
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables MacOS in CI (both x86 and arm64). The purpose is not to enable dev on Mac (although I do dev on my MBP sometimes) but moreso to have another build system to sniff out build issues. Indeed a couple are on display right here. In addition, we discover that one of the
pad_pack_matmulsamples has a bug that is somehow covered up on Linux and only flaky on Windows (on Mac we are a consistent fail).