[canonicalization] Add AMDAIEDialectFoldInterface to keeps ops in amdaie.cores #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
|
@makslevental I don't think there's a way to do this in the .td file. |
Yea I looked around and came to the same conclusion - can you put a note in both places (AIEOps.td and AMEAIEOps.td) about this annoying fact. |
newling
force-pushed
the
keep_cores_isolated
branch
from
65e89f4 to
05e526b
Compare
makslevental
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://mlir.llvm.org/docs/Canonicalization/#globally-applied-rules
Copied from AIE dialect, which does the same thing for
aie.core