Set ObjectFifo pipeline as default and some cleanup #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang93
requested review from
MaheshRavishankar,
nirvedhmeshram,
Abhishek-Varma and
jtuyls
as code owners
erwei-xilinx
approved these changes
Aug 29, 2024
newling
reviewed
Aug 29, 2024
| # --m "52" --n "52" --k "63" \ | ||
| # --expect_compile_failure "1" | ||
|
|
||
| # Example of a run with a group of 2+ matmuls. Currently this test is passed |
There was a problem hiding this comment.
Why is this comment removed?
There was a problem hiding this comment.
Thanks for catching it!
yzhang93
force-pushed
the
cleanup_test
branch
3 times, most recently
from
4a051f1 to
b3196b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously, we are now setting pack-peel and objectfifo pipeline as default.
Some cleanup including:
numCoreswhich was added for historical task, but is no longer used.