Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCLBinGen] Fix chess core elf generation #728

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Aug 30, 2024

When chess is enabled, the core elf generation returns early instead of generating an elf for all cores, leading to the following error:

Run: PATH=/home/jorn/workspace/Vitis/2024.2/aietools/tps/lnx64/target_aie2p/bin/LNa64bin:/opt/xilinx/xrt/bin:/opt/xilinx/xrt/bin:/home/jorn/miniconda3/bin:/home/jorn/miniconda3/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin LD_LIBRARY_PATH=/home/jorn/workspace/Vitis/2024.2/aietools/lib/lnx64.o:/home/jorn/workspace/Vitis/2024.2/aietools/lnx64/tools/dot/lib:/opt/xilinx/xrt/lib:/opt/xilinx/xrt/lib RDI_DATADIR=/home/jorn/workspace/Vitis/2024.2/aietools/data XILINXD_LICENSE_FILE=/home/jorn/workspace/iree-amd-aie/../Xilinx.lic /home/jorn/workspace/Vitis/2024.2/aietools/bin/unwrapped/lnx64.o/xchesscc -j1 -pme -P/home/jorn/workspace/Vitis/2024.2/aietools/data/aie2p/lib -f -CRelease_LLVM +w/home/jorn/workspace/iree-amelf doesn't exist: /home/jorn/workspace/iree-amd-aie/test_matmuls/module_matmul_32x32_32xi32__dispatch_0_amdaie_xclbin_fb/core_0_3.elf
failed to emit CDOFailed to generate CDO

I noticed this on Strix with chess, but I don't understand yet why the CI is not catching the same issue on Phoenix with chess enabled.

@makslevental
Copy link
Collaborator

The tests in CI for Phoenix are single core.

Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one multi-core test at the bottom of run_matmul_test.sh`.

@jtuyls
Copy link
Collaborator Author

jtuyls commented Aug 30, 2024

The tests in CI for Phoenix are single core.

Can you add one multi-core test at the bottom of run_matmul_test.sh`.

Thanks, will do!

@jtuyls jtuyls force-pushed the fix-strix-core-elf-generation branch from fe93e12 to 4f5a888 Compare August 30, 2024 13:03
@jtuyls jtuyls merged commit cc68d51 into nod-ai:main Aug 30, 2024
6 checks passed
@jtuyls jtuyls deleted the fix-strix-core-elf-generation branch August 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants