-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObjectFifo] Add a pass to combine logical objFifos for connection reuse #760
Draft
Abhishek-Varma
wants to merge
7
commits into
main
Choose a base branch
from
avarma_followup_combine_objFifos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9ff292
[ObjectFifo] Add a pass to combine logical objFifos for connection reuse
Abhishek-Varma c8b650c
Review comments v1
Abhishek-Varma d30ec7f
TEMPORARY commit to see Mac test failure via CI
Abhishek-Varma 4f0caea
Assign correct tiles to reusable L1 buffer
Abhishek-Varma 4070f8f
Windows DEBUG
Abhishek-Varma 7c648f9
Store previous L1 buffers and use later
Abhishek-Varma 86ecf18
Replace old l1 with new reusable
Abhishek-Varma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...target/AMD-AIE/iree-amd-aie/Transforms/AMDAIECombineLogicalObjFifosForConnectionReuse.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// Copyright 2024 The IREE Authors | ||
// | ||
// Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
#include "iree-amd-aie/IR/AMDAIEOps.h" | ||
#include "iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.h" | ||
#include "iree-amd-aie/Transforms/Passes.h" | ||
#include "mlir/IR/Iterators.h" | ||
#include "mlir/Pass/Pass.h" | ||
|
||
#define DEBUG_TYPE \ | ||
"iree-amdaie-combine-logical-objectfifos-for-connection-reuse" | ||
|
||
namespace mlir::iree_compiler::AMDAIE { | ||
|
||
namespace { | ||
|
||
class AMDAIECombineLogicalObjFifosForConnectionReusePass | ||
: public impl::AMDAIECombineLogicalObjFifosForConnectionReuseBase< | ||
AMDAIECombineLogicalObjFifosForConnectionReusePass> { | ||
public: | ||
using AMDAIECombineLogicalObjFifosForConnectionReuseBase:: | ||
AMDAIECombineLogicalObjFifosForConnectionReuseBase; | ||
|
||
void getDependentDialects(DialectRegistry ®istry) const override { | ||
registry.insert<AMDAIEDialect>(); | ||
} | ||
void runOnOperation() override; | ||
}; | ||
|
||
void AMDAIECombineLogicalObjFifosForConnectionReusePass::runOnOperation() { | ||
ModuleOp moduleOp = getOperation(); | ||
MLIRContext *context = &getContext(); | ||
IRRewriter rewriter(context); | ||
|
||
SmallVector<AMDAIE::DmaCpyNdOp> l2ToL1DmaOps = | ||
fetchDmaCpyNdOpsToSplitOrCombine(moduleOp); | ||
|
||
if (failed(combineLogicalObjectFifos(rewriter, l2ToL1DmaOps, context))) { | ||
return signalPassFailure(); | ||
} | ||
} | ||
|
||
} // namespace | ||
|
||
std::unique_ptr<Pass> | ||
createAMDAIECombineLogicalObjFifosForConnectionReusePass() { | ||
return std::make_unique<AMDAIECombineLogicalObjFifosForConnectionReusePass>(); | ||
} | ||
|
||
} // namespace mlir::iree_compiler::AMDAIE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reason
test_transaction
isn't generated on Windows...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e., once you put this back to
Release
Windows will pass again.