-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObjectFifo] Create a pass to convert temporary alloc to amdaie.buffer #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- This commit creates a pass `iree-amdaie-temporary-alloc-bufferization` to convert temporary alloc/buffers to amdaie.buffer ops. Signed-off-by: Abhishek Varma <[email protected]>
Abhishek-Varma
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
jtuyls
as code owners
September 18, 2024 08:18
jtuyls
reviewed
Sep 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/temporary_alloc_bufferization.mlir
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIETemporaryAllocBufferization.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIETemporaryAllocBufferization.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIETemporaryAllocBufferization.cpp
Outdated
Show resolved
Hide resolved
jtuyls
reviewed
Sep 18, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIETemporaryAllocBufferization.cpp
Outdated
Show resolved
Hide resolved
jtuyls
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit.
Abhishek-Varma
force-pushed
the
avarma_temp_buffer_pass
branch
from
September 18, 2024 12:33
8351f01
to
91b375d
Compare
daveliddell
pushed a commit
to daveliddell/iree-amd-aie
that referenced
this pull request
Oct 7, 2024
nod-ai#783) -- This commit creates a pass `iree-amdaie-temporary-alloc-bufferization` to convert temporary alloc/buffers to amdaie.buffer ops. Signed-off-by: Abhishek Varma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This commit creates a pass
iree-amdaie-temporary-alloc-bufferization
to convert temporary alloc/buffers to amdaie.buffer ops.
Signed-off-by: Abhishek Varma [email protected]