[ConvertToUnpack] Apply correct permutation when lowering unpack to DMA #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
daveliddell
pushed a commit
to daveliddell/iree-amd-aie
that referenced
this pull request
Oct 7, 2024
…MA (nod-ai#794) Inverse permutation needs to be applied when converting unpack to DMA, not permutation. PR adds test with permutation P != P^{-1}, without which this bug is hidden. I've left a comment with that test explaining why this fix is required. Also, `--cse` is removed from the test lit command, to reduce noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverse permutation needs to be applied when converting unpack to DMA, not permutation. PR adds test with permutation P != P^{-1}, without which this bug is hidden. I've left a comment with that test explaining why this fix is required. Also,
--cseis removed from the test lit command, to reduce noise.