Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chesshack #803

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Remove chesshack #803

merged 2 commits into from
Sep 27, 2024

Conversation

makslevental
Copy link
Collaborator

@makslevental makslevental commented Sep 27, 2024 •
edited
Loading

As of 2024.2, Chess has caught up to LLVM. This will unblock #732 (i.e., aiesimulator support).

@makslevental makslevental force-pushed the makslevental/remove-chess-hack branch from 426559e to 45a6021 Compare September 27, 2024 02:44
@makslevental makslevental changed the title [WIP] remove chesshack Remove chesshack Sep 27, 2024
@makslevental makslevental requested a review from jtuyls September 27, 2024 02:55
@makslevental makslevental marked this pull request as ready for review September 27, 2024 02:56
newling
newling approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@newling newling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't resist with a PR title like this

@makslevental makslevental force-pushed the makslevental/remove-chess-hack branch from 45a6021 to 12e2190 Compare September 27, 2024 03:15
@makslevental makslevental enabled auto-merge (squash) September 27, 2024 03:15
@makslevental makslevental merged commit a2697b2 into main Sep 27, 2024
6 checks passed
@makslevental makslevental deleted the makslevental/remove-chess-hack branch September 27, 2024 03:39
daveliddell pushed a commit to daveliddell/iree-amd-aie that referenced this pull request Oct 7, 2024
@makslevental @daveliddell
Remove chesshack (nod-ai#803)
9a232a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newling newling newling approved these changes

@jtuyls jtuyls Awaiting requested review from jtuyls

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @newling