[CombineStridedOps] Add support for NpuCircularDmaCpyNdOp
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
Abhishek-Varma
as code owners
Abhishek-Varma
requested changes
Dec 6, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIECombineStridedOps.cpp
Outdated
Show resolved
Hide resolved
jtuyls
force-pushed
the
combine-strided-ops-circular-dma
branch
from
d9fc43b to
299394a
Compare
Abhishek-Varma
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks @jtuyls ! Code looks cleaner now!
LGTM % one request change.
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIECombineStridedOps.cpp
Show resolved
Hide resolved
jtuyls
force-pushed
the
combine-strided-ops-circular-dma
branch
from
299394a to
c5a6ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.