Move AMDAIEAssignChannelsPass before AMDAIEAssignNpuDmaBdIdsPass #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
requested changes
Dec 11, 2024
| @@ -61,6 +61,32 @@ FailureOr<AMDAIE::TileOp> getGeneratorTileOp( | |||
| return tileOp; | |||
| }; | |||
|
|
|||
| /// Utility to retrieve a ChannelOp from a DMA copy operation. | |||
| template <CopyOpOperateOn OperateOn> | |||
| FailureOr<AMDAIE::ChannelOp> getChannelOp(AMDAIE::NpuDmaCpyNdOp &npuDmaOp) { | |||
There was a problem hiding this comment.
To make this reusable, could you make this a method of NpuDmaCpyNdOp instead? You likely need to expose it as getSourceChannelOp and getTargetChannelOp and use this function under the hood.
Comment on lines
185
to
186
| AMDAIE::ChannelOp channelOp = maybeChannelOp.value(); | ||
| uint32_t channel = channelOp.getValue(); |
There was a problem hiding this comment.
Suggested change
| AMDAIE::ChannelOp channelOp = maybeChannelOp.value(); | |
| uint32_t channel = channelOp.getValue(); | |
| uint32_t channel = maybeChannelOp.value().getValue(); |
…d-aie into zhewen_moveAssignChannels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve the following comment:
iree-amd-aie/compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEAssignNpuDmaBdIds.cpp
Lines 269 to 274 in e623a6a
ChannelOpfrom givenNpuDmaCpyNdOpassign-npu-dma-bd-ids.mliris refactored