-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds arg for exec file dump dir, instruction counter script #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We should be able to add more stats to this easily
Updated results with the counter stopping fixed: Potential follow-ups:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nit
Co-authored-by: Jakub Kuderski <[email protected]>
Co-authored-by: Jakub Kuderski <[email protected]>
Adds the --exec_dump_dir flag to the gemmbench script and creates a script for generating a .csv with instruction counts (naive) from dumped .rocmasm files.
By naive, I mean it starts counting lines at "Kernarg preload header" and stops at "---" to count instructions.
@kuhar is the stopping criteria here too late? it includes what seems to be metadata, so maybe it should stop at "s_endpgm" or "func_end0"?
Perhaps some of the counter utilities should be further integrated into the benchmarking tooling.
The instruction counter generates a file like this (also attached):
rocmasm_line_counts.csv