Update attention template #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ths commit updates the attention template to include promote operands and decomposition_config. Signed-off-by: Manupa Karunaratne <[email protected]>
|
Thanks, can you also change this line https://github.com/nod-ai/iree-kernel-benchmark/blob/main/.github/workflows/run_bench.yml#L19 to |
|
Thanks @saienduri can you "suggest" the change? .. so that I can commit it :). I need to setup ssh on the machine im currently in to change a workflow as PAT does not allow that. |
|
nvm let me setup ssh... I dont think you can suggest as it is not changed in the PR. |
|
Cool, you can also just use the github UI and edit the file on your branch if it's too much trouble |
|
@saienduri thanks for the tip! i did not know about GH UI :o |
saienduri
approved these changes
Nov 1, 2024
|
@saienduri as first timer here, who should merge the PR :) ? |
|
Once you get an approval, go for it :). Merging it now though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths commit updates the attention
template to include promote operands
and decomposition_config.