[tuner] Add device validation for user devices #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
requested changes
Jul 17, 2024
kuhar
reviewed
Jul 17, 2024
RattataKing
suggested changes
Jul 17, 2024
kuhar
reviewed
Jul 23, 2024
kuhar
reviewed
Jul 23, 2024
mihaescuvlad
force-pushed
the
users/mihaescuvlad/add-devices-validation
branch
from
432261b to
4e5c139
Compare
kuhar
changed the title
kuhar
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Looks good! Could you add a couple of test cases for extract_driver_name and parse_devices to test_autotune.py? And also address this: #60 (review).
Initial changes did not fully commit Optimized validation & implemented CR suggestions Fix merge issues Add device validation for user devices Initial changes did not fully commit Optimized validation & implemented CR suggestions Add device validation for user devices Optimized validation & implemented CR suggestions Fix merge issues Add device validation for user devices Optimized validation & implemented CR suggestions Add unit tests for autotuning Update benchmark scripts to take in any device
mihaescuvlad
force-pushed
the
users/mihaescuvlad/add-devices-validation
branch
from
95ef174 to
72c58a6
Compare
kuhar
approved these changes
Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input will be verified against the available devices on the user's machine.
The old implementation of
--deviceswas taking in an integer, it will now take in a string representing the device's Path / UUID.fetch_available_devices() -> list[any]- Returns the list of all of the devices found by the IREE Runtime modulevalidate_devices(user_devices) -> None- Takes in the user input and checks it against the available devices and throws an error if at least one of the user's devices is invalid.parse_devices(devices_str: str) -> list[str]- The documentation of the method has been updated andvalidate_deviceswill be called to validate the user inputparse_arguments()- The help message has been updated to better represent what the new input format for--devicesis expected to look likeBnechmarking->Benchmarking