Skip to content

Commit

Permalink
Fix iree_hal_buffer_subspan after change in iree.
Browse files Browse the repository at this point in the history
  • Loading branch information
AWoloszyn committed Dec 11, 2024
1 parent 4c015d4 commit 4b92260
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion shortfin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if(NOT WIN32)
endif()

# Pins
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241204")
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241211")

# build options
option(SHORTFIN_BUILD_PYTHON_BINDINGS "Builds Python Bindings" OFF)
Expand Down
4 changes: 2 additions & 2 deletions shortfin/requirements-iree-compiler.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Keep in sync with "ref: iree-" in .github/workflows/* and GIT_TAG in CMakeLists.txt
-f https://iree.dev/pip-release-links.html
iree-base-compiler==3.1.0rc20241204
iree-base-runtime==3.1.0rc20241204
iree-base-compiler==3.1.0rc20241211
iree-base-runtime==3.1.0rc20241211
4 changes: 3 additions & 1 deletion shortfin/src/shortfin/array/storage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ storage storage::subspan(iree_device_size_t byte_offset,
iree_device_size_t byte_length) {
storage new_storage(device_, {}, timeline_resource_);
SHORTFIN_THROW_IF_ERROR(iree_hal_buffer_subspan(
buffer_, byte_offset, byte_length, new_storage.buffer_.for_output()));
buffer_, byte_offset, byte_length,
iree_hal_device_host_allocator(device_.raw_device()->hal_device()),
new_storage.buffer_.for_output()));
return new_storage;
}

Expand Down

0 comments on commit 4b92260

Please sign in to comment.