Skip to content

Commit

Permalink
Set paths for tuner and shortfin workflows consistently. (#298)
Browse files Browse the repository at this point in the history
Now these workflows will only run if files in one of these subproject
directories are touched.

This sets triggers consistently for `pull_request` and `push` events. In
other projects we've set all workflows to run on `push` events. We could
do that here too, just in case these triggers miss something prior to
merge.

Note that using `paths` filters on `pull_request` triggers breaks
"required checks". We currently only set `pre-commit` and `Unit Tests
and Type Checking (3.11, ubuntu-latest)` as required checks though.

Another option is to just always run these workflows with no filters at
all. The workflows are using free runners and are pretty fast (~5
minutes), so the predictability could be nice.
  • Loading branch information
ScottTodd authored Oct 21, 2024
1 parent d181d67 commit 752b090
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci-tuner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,15 @@ name: CI - Tuner
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci-tuner.yml'
- 'tuner/**'
push:
branches:
- main
paths:
- '.github/workflows/ci-tuner.yml'
- 'tuner/**'

concurrency:
group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci_linux_x64-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ name: CI - shortfin
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_linux_x64-libshortfin.yml'
- 'shortfin/**'
push:
branches:
- main
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci_linux_x64_asan-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ name: CI - shortfin - ASan
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_linux_x64_asan-libshortfin.yml'
- 'shortfin/**'
push:
branches:
- main
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ci_linux_x64_nogil-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ name: CI - shortfin - Python 3.13 Free-threaded
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_linux_x64-libshortfin.yml'
- 'shortfin/**'

push:
branches:
- main
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci_windows_x64-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ name: CI - shortfin - Windows
on:
workflow_dispatch:
pull_request:
paths:
- '.github/workflows/ci_windows_x64-libshortfin.yml'
- 'shortfin/**'
push:
branches:
- main
Expand Down

0 comments on commit 752b090

Please sign in to comment.