Skip to content

Commit

Permalink
Fix workflows installing nightly IREE packages to use --pre. (#506)
Browse files Browse the repository at this point in the history
Pip will only install "pre-release" versions if `--pre` is set or the
version is set explicitly:
https://pip.pypa.io/en/stable/cli/pip_install/#pre-release-versions. The
`rc` part of our `rcYYYYMMDD` suffix used in the nightly IREE packages
is considered a "Pre-release segment" in the version string:
https://packaging.python.org/en/latest/specifications/version-specifiers/#public-version-identifiers.

This should change workflow jobs like
https://github.com/nod-ai/SHARK-Platform/actions/runs/11827078971/job/32954462017#step:5:163
that have been downloading `iree-base-compiler-2.9.0
iree-base-runtime-2.9.0` to downloading the latest nightly versions
instead, as they intend:
https://github.com/nod-ai/SHARK-Platform/blob/51cf2f45139f67e15434990173b49375998db9f3/.github/workflows/ci-sharktank.yml#L64-L67

Co-authored-by: Marius Brehler <[email protected]>
  • Loading branch information
ScottTodd and marbre authored Nov 14, 2024
1 parent 9d45921 commit f429c91
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-shark-platform.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
# Try with the latest IREE nightly releases, not what iree-turbine pins.
# We could also pin to a known working or stable version.
# This should eventually stabilize. Do the best we can for now.
pip install -f https://iree.dev/pip-release-links.html --upgrade \
pip install -f https://iree.dev/pip-release-links.html --upgrade --pre \
iree-base-compiler \
iree-base-runtime \
"numpy<2.0"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-sharktank.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
pip install --no-compile -r requirements.txt -r sharktank/requirements-tests.txt -e sharktank/
# Update to the latest iree packages.
pip install -f https://iree.dev/pip-release-links.html --upgrade \
pip install -f https://iree.dev/pip-release-links.html --upgrade --pre \
iree-base-compiler iree-base-runtime --src deps \
-e "git+https://github.com/iree-org/iree-turbine.git#egg=iree-turbine"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-tuner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
pip install -r tuner/requirements-tuner.txt
python -m pip install \
--find-links https://iree.dev/pip-release-links.html \
--upgrade \
--upgrade --pre \
iree-base-compiler iree-base-runtime
- name: Run tuner tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_eval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
# Try with the latest IREE nightly releases, not what iree-turbine pins.
# We could also pin to a known working or stable version.
# This should eventually stabilize. Do the best we can for now.
pip install -f https://iree.dev/pip-release-links.html --upgrade \
pip install -f https://iree.dev/pip-release-links.html --upgrade --pre \
iree-base-compiler \
iree-base-runtime \
"numpy<2.0"
Expand Down

0 comments on commit f429c91

Please sign in to comment.