-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuner] Add candidate generator script #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to this PR and say what the plan is wrt landing the tuner.
Also please include the unit tests together with the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments from an initial scan. Definitely want to resolve the github workflow / requirement file topics before merge here. Could defer the script refactoring.
c5c8085
to
2bedfdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A README.md
in sharktank/tools/tuner/
would be helpful too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the cleanups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new location looks good to me
The plan is to move the tuner from the sdxl-scripts repo to the sharktank repo.
This PR is the first step, moving
candidate_gen.py
(the candidate generator for tuning) along with its CI and unit tests.More changes will come to fully decouple it.
New changes in
candidate_gen.py
:LLVMGPUVectorDistribute
candidate_gen_test.py
:candidate_gen.py