Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libshortfin] Clean up a few CI related items. #163

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

stellaraccident
Copy link
Contributor

@stellaraccident stellaraccident commented Sep 3, 2024

  • Disables ASAN ODR check properly (had syntax error in env var).
  • Builds non-debug Python.
  • Sets up LSAN suppressions to account for non-debug Python intentional leaks.
  • Has CMake fetch the correct nanobind vs relying on pip (had another incident of mismatched version).
  • Added options SHORTFIN_BUILD_STATIC=OFF, SHORTFIN_BUILD_DYNAMIC=ON, and SHORTFIN_LINK_DYNAMIC to control variants of libraries produced and linked to (disabling static in most configs saves a lot of build time).
  • Run pytest with -s (stream output) option. For some reason, some of the subprocess tests are otherwise not working right on GHA runners. It looks like there may be some malformed I/O somewhere that gets less reliable with redirection. This isn't solved but does increase the chance of passing.

@stellaraccident stellaraccident marked this pull request as ready for review September 3, 2024 23:22
@stellaraccident stellaraccident merged commit 949e43f into main Sep 3, 2024
6 of 7 checks passed
@stellaraccident stellaraccident deleted the libshortfin_ci_cleanup branch September 3, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant