Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device selection to shortfin llm demo #275

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Add device selection to shortfin llm demo #275

merged 6 commits into from
Oct 17, 2024

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Oct 11, 2024

No description provided.

@renxida renxida changed the title Shortfin system selection Add device selection to shortfin llm demo Oct 11, 2024
@renxida renxida force-pushed the shortfin-system-selection branch from cd6ef16 to a667fbb Compare October 14, 2024 16:43
@renxida renxida requested a review from monorimet October 14, 2024 16:44
@renxida renxida marked this pull request as ready for review October 14, 2024 16:51
@renxida renxida force-pushed the shortfin-system-selection branch from 6697077 to cde99ed Compare October 15, 2024 15:06
monorimet
monorimet approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: good to work this into a proper test structure instead of loose shellscript tests.
Otherwise, LGTM

@renxida renxida force-pushed the shortfin-system-selection branch from a38e87c to 30a6a4c Compare October 16, 2024 15:56
@renxida
Copy link
Contributor Author

renxida commented Oct 16, 2024

good idea. working it into the pytest infra.

@renxida renxida force-pushed the shortfin-system-selection branch from b2ede02 to 74484fa Compare October 17, 2024 13:14
@renxida renxida merged commit 0c48865 into nod-ai:main Oct 17, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monorimet monorimet monorimet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renxida @monorimet