[sharktank] Evaluation - Add Perplexity test #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
The diff between the original and this PR looks good to make progress while keeping the other CI builds working.
I would like to see my other comments addressed at some point though:
- Have the test download/cache the input gguf/json files instead of assume that they exist at some
/data/extra/models/path on the CI runner, so developers can also run these tests themselves. - Organize
requirements.txtintosharktank/requirements-tests.txtso we can track what each subproject needs for devs/users/tests at a fine granularity.
Co-authored-by: Scott Todd <[email protected]>
…tform into perplexity-test
IanNod
reviewed
Oct 17, 2024
…tform into perplexity-test
IanNod
approved these changes
Oct 18, 2024
| @@ -0,0 +1,213 @@ | |||
| { | |||
There was a problem hiding this comment.
can we just store these values in a npy file or something and retrieve from sharkblobs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Perplexity test for LLM evaluation