Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MMDIT block that is necessary for flux #592

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Implement MMDIT block that is necessary for flux #592

merged 10 commits into from
Dec 4, 2024

Conversation

KyleHerndon
Copy link
Contributor

No description provided.

@KyleHerndon KyleHerndon force-pushed the mmdit branch 2 times, most recently from 2da353b to 7177d2d Compare November 22, 2024 18:24
@KyleHerndon KyleHerndon marked this pull request as draft November 22, 2024 18:42
@KyleHerndon KyleHerndon force-pushed the mmdit branch 2 times, most recently from 4e2e1a4 to e52a667 Compare November 22, 2024 19:25
@KyleHerndon KyleHerndon marked this pull request as ready for review November 22, 2024 22:53
sogartar
sogartar approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@sogartar sogartar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a few questions. And a few suggestions that can be addressed now or later.

sharktank/sharktank/layers/mmdit_double.py Outdated Show resolved Hide resolved
sharktank/sharktank/layers/mmdit_double.py Outdated Show resolved Hide resolved
sharktank/tests/layers/mmdit_test.py Outdated Show resolved Hide resolved
sharktank/sharktank/ops/default_impls.py Outdated Show resolved Hide resolved
sharktank/sharktank/layers/testing.py Show resolved Hide resolved
sharktank/sharktank/layers/mmdit_double.py Outdated Show resolved Hide resolved
sharktank/sharktank/layers/mmdit_double.py Outdated Show resolved Hide resolved
sharktank/sharktank/layers/modulation.py Show resolved Hide resolved
@KyleHerndon KyleHerndon merged commit 4205771 into main Dec 4, 2024
8 checks passed
@KyleHerndon KyleHerndon deleted the mmdit branch December 4, 2024 19:24
monorimet pushed a commit that referenced this pull request Dec 13, 2024
@KyleHerndon @eagarvey-amd
Implement MMDIT block that is necessary for flux (#592)
680cd6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archana-ramalingam archana-ramalingam archana-ramalingam left review comments

@sogartar sogartar sogartar approved these changes

@IanNod IanNod Awaiting requested review from IanNod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleHerndon @sogartar @archana-ramalingam