Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a DPP intro in amdgpu_kernel_optimization_guide.md #598

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add a DPP intro in amdgpu_kernel_optimization_guide.md #598

merged 3 commits into from
Nov 25, 2024

Conversation

knwng
Copy link
Contributor

@knwng knwng commented Nov 23, 2024

No description provided.

@knwng knwng requested a review from kuhar November 23, 2024 00:06
@knwng knwng force-pushed the add_dpp_doc branch 2 times, most recently from f822c8c to 0000ebb Compare November 23, 2024 00:33
kuhar
kuhar reviewed Nov 23, 2024
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for writing this up @knwng!

Also please update the header at the very top of the file.

docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
@knwng knwng requested a review from kuhar November 23, 2024 02:50
kuhar
kuhar approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you rewrap lines before we merge this? In vscode there's a command for this under Alt + Q.

docs/amdgpu_kernel_optimization_guide.md Outdated Show resolved Hide resolved
@knwng knwng enabled auto-merge (squash) November 25, 2024 00:40
@knwng knwng merged commit bf8540f into nod-ai:main Nov 25, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knwng @kuhar