See if stale dependencies are causing shortfin server to fail to start #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We started seeing a failure in
Shortfin CPU LLM Integration Testafter merging #601. However, the only aspect of the integration test that that PR touches is a fix in the logger:Old
New
That shouldn't have an impact on the test, and while reading the output of the workflow, it didn't seem to be the line that caused the server to not start.
When testing locally in a fresh environment, the test ran fine, which made me think that it may be related to stale dependencies. I updated the hash of cached pip to take into account requirement changes in
sharktankandshortfin, which appears to fix the test.