Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner]: retire data class GPUPipelineOptions, use iree_gpu.PipelineOptionsAttr. #626

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

bangtianliu
Copy link
Contributor

This PR is relevant to task: Use IREE bindings for compilation info (incl., lowering_config and translation_info) in #453.

Retire data class GPUPipelineOptions, use python binding iree_gpu.PipelineOptionsAttr instead.

@bangtianliu bangtianliu requested a review from kuhar November 27, 2024 23:11
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one issue

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhar kuhar merged commit ba8dd7d into nod-ai:main Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants