-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuner]: use lowering config binding #629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
force-pushed
the
use_lowering_config
branch
from
November 28, 2024 23:02
ee04297
to
589900d
Compare
13 tasks
kuhar
requested changes
Nov 29, 2024
kuhar
reviewed
Nov 29, 2024
kuhar
reviewed
Dec 1, 2024
kuhar
reviewed
Dec 2, 2024
kuhar
reviewed
Dec 2, 2024
bangtianliu
force-pushed
the
use_lowering_config
branch
from
December 2, 2024 20:03
40a38cd
to
2f1a638
Compare
kuhar
reviewed
Dec 2, 2024
kuhar
reviewed
Dec 3, 2024
bangtianliu
force-pushed
the
use_lowering_config
branch
from
December 3, 2024 00:42
bb7e1e9
to
69ae392
Compare
kuhar
reviewed
Dec 3, 2024
kuhar
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the fixes.
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
force-pushed
the
use_lowering_config
branch
from
December 3, 2024 05:38
bafda82
to
07919e4
Compare
monorimet
pushed a commit
that referenced
this pull request
Dec 13, 2024
This PR is relevant to the task in #453 : use IREE bindings for compilation info (incl., lowering_config and translation_info). Remove data class `ReorderWorkgroupsStrategy`, and use lowering_config binding. --------- Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relevant to the task in #453 : use IREE bindings for compilation info (incl., lowering_config and translation_info).
Remove data class
ReorderWorkgroupsStrategy
, and use lowering_config binding.