[shortfin] Disable C++ tests in package builds. #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbre
approved these changes
Dec 4, 2024
monorimet
pushed a commit
that referenced
this pull request
Dec 13, 2024
Progress on #584. This is expected to save around 10-20 seconds when building packages on standard GitHub-hosted runners: ``` Tue, 03 Dec 2024 11:07:18 GMT [372/380] Linking CXX shared library src/libshortfin.so.3.1.0 Tue, 03 Dec 2024 11:07:18 GMT [373/380] Creating library symlink src/libshortfin.so.1 src/libshortfin.so Tue, 03 Dec 2024 11:07:23 GMT [374/380] Linking CXX executable src/shortfin/support/shortfin_support_test Tue, 03 Dec 2024 11:07:23 GMT [375/380] Linking CXX executable src/shortfin/array/shortfin_array_test Tue, 03 Dec 2024 11:07:36 GMT [376/380] Building CXX object python/CMakeFiles/shortfin_python_extension.dir/array_host_ops.cc.o Tue, 03 Dec 2024 11:07:45 GMT [377/380] Linking CXX shared module python/_shortfin_default/lib.cpython-311-x86_64-linux-gnu.so ``` (from these logs: https://github.com/nod-ai/shark-ai/actions/runs/12138320160/job/33843543941#step:6:738) IREE also disables its tests when building packages: * https://github.com/iree-org/iree/blob/cbb11f220c69e0106dbfd1533a00237c3a74e7e3/compiler/setup.py#L260 * https://github.com/iree-org/iree/blob/cbb11f220c69e0106dbfd1533a00237c3a74e7e3/runtime/setup.py#L278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #584.
This is expected to save around 10-20 seconds when building packages on standard GitHub-hosted runners:
(from these logs: https://github.com/nod-ai/shark-ai/actions/runs/12138320160/job/33843543941#step:6:738)
IREE also disables its tests when building packages: