Workflow cleanup: move checkout to start, prune unused steps+vars. #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah. Thanks for noticing. Sent #642 |
ScottTodd
added a commit
that referenced
this pull request
Dec 4, 2024
Missed these as part of #639 (too many workflows 😵 )
monorimet
pushed a commit
that referenced
this pull request
Dec 13, 2024
) Cutting down on boilerplate and standardizing some workflow syntax before deeper refactoring work. * Move `users: actions/checkout` to the start of each job (for consistency, since all workflows use the source code but not all workflows need dependencies or python setup, etc.) * Per https://github.com/actions/checkout, `submodules: false` is the default * Step names can be omitted with `uses` (docs: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_iduses) . Our [`pre-commit.yml`](https://github.com/nod-ai/shark-ai/blob/main/.github/workflows/pre-commit.yaml) workflow does this already: https://github.com/nod-ai/shark-ai/blob/c0ca2e2788ea09a890ffe347dfbffe57606670b8/.github/workflows/pre-commit.yaml#L11-L14  * Remove copy/pasted `Get Current Date` step from some workflows * Remove unused `SHARK_PLATFORM_REPO_ROOT` env var from some workflows (unused since #305, copy/pasted into a few places)
monorimet
pushed a commit
that referenced
this pull request
Dec 13, 2024
Missed these as part of #639 (too many workflows 😵 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cutting down on boilerplate and standardizing some workflow syntax before deeper refactoring work.
users: actions/checkoutto the start of each job (for consistency, since all workflows use the source code but not all workflows need dependencies or python setup, etc.)submodules: falseis the defaultuses(docs: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_iduses) . Ourpre-commit.ymlworkflow does this already:shark-ai/.github/workflows/pre-commit.yaml
Lines 11 to 14 in c0ca2e2
Get Current Datestep from some workflowsSHARK_PLATFORM_REPO_ROOTenv var from some workflows (unused since [sharktank] Evaluation - Update timeout for Perplexity CI test #305, copy/pasted into a few places)