-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch workflows to use new nightly iree-turbine packages. #657
Conversation
iree-base-compiler \ | ||
iree-base-runtime | ||
iree-base-runtime \ | ||
iree-turbine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: Shouldn't installing iree-turbine
get us the latest/relevant version of compiler and runtime. Do we have to explicitly install/update them too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Good question. It does.
pip install --find-links https://iree.dev/pip-release-links.html iree-turbine --upgrade --pre
Collecting iree-turbine
Downloading https://github.com/iree-org/iree-turbine/releases/download/dev-wheels/iree_turbine-3.1.0rc20241206-py3-none-any.whl (292 kB)
---------------------------------------- 292.3/292.3 kB 18.8 MB/s eta 0:00:00
Collecting numpy
Downloading numpy-2.2.0rc1-cp311-cp311-win_amd64.whl (12.9 MB)
---------------------------------------- 12.9/12.9 MB 81.8 MB/s eta 0:00:00
Collecting iree-base-compiler
Downloading https://github.com/iree-org/iree/releases/download/iree-3.1.0rc20241206/iree_base_compiler-3.1.0rc20241206-cp311-cp311-win_amd64.whl (49.3 MB)
---------------------------------------- 49.3/49.3 MB 34.4 MB/s eta 0:00:00
Collecting iree-base-runtime
Downloading https://github.com/iree-org/iree/releases/download/iree-3.1.0rc20241206/iree_base_runtime-3.1.0rc20241206-cp311-cp311-win_amd64.whl (5.3 MB)
---------------------------------------- 5.3/5.3 MB 15.5 MB/s eta 0:00:00
pip freeze
filelock==3.16.1
fsspec==2024.10.0
iree-base-compiler==3.1.0rc20241206
iree-base-runtime==3.1.0rc20241206
iree-turbine==3.1.0rc20241206
Jinja2==3.1.4
MarkupSafe==3.0.2
ml_dtypes==0.5.0
mpmath==1.3.0
networkx==3.4.2
numpy==2.2.0rc1
sympy==1.13.1
torch==2.5.1
typing_extensions==4.12.2
On one hand, we could do the minimal thing and install just iree-turbine
and let it pull the other deps. On the other, we could be explicit, which I think I like more, given how we do directly use some of the underlying packages:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I also prefer being explicit and not letting iree-turbine
pulling in the IREE base packages.
This simplification will help with #584.
Nightly releases of iree-turbine are now being built thanks to iree-org/iree-turbine#314 and published at the same index as the other IREE packages thanks to iree-org/iree#19391.