Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner]: use property function from iree lowering config python binding #662

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

bangtianliu
Copy link
Contributor

After landing iree-org/iree#19376, all helper functions related to lowering configuration can be removed. Instead, we can directly utilize property functions from the LoweringConfig Python bindings.

This PR is still relevant to the task in #453: use IREE bindings for compilation info (incl., lowering_config and translation_info).

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % formatting

tuner/tuner/dispatch_parser_test.py Outdated Show resolved Hide resolved
@bangtianliu bangtianliu force-pushed the lowering_config_helper branch from 89e7b1a to 1da3fe4 Compare December 9, 2024 20:14
@bangtianliu bangtianliu merged commit bcc4ad5 into nod-ai:main Dec 9, 2024
9 checks passed
IanNod pushed a commit to IanNod/SHARK-Platform that referenced this pull request Dec 17, 2024
…ng (nod-ai#662)

After landing iree-org/iree#19376, all helper
functions related to lowering configuration can be removed. Instead, we
can directly utilize property functions from the LoweringConfig Python
bindings.

This PR is still relevant to the task in
nod-ai#453: use IREE bindings for
compilation info (incl., lowering_config and translation_info).

---------

Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants