-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enums] monkey patch register_attribute_builder
#670
Merged
makslevental
merged 6 commits into
main
from
makslevental/hack-register_attribute_builder
Dec 10, 2024
Merged
[enums] monkey patch register_attribute_builder
#670
makslevental
merged 6 commits into
main
from
makslevental/hack-register_attribute_builder
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e268dfb
to
5c9c80d
Compare
register_attribute_builder
register_attribute_builder
fail without the monkey-patch https://github.com/nod-ai/shark-ai/actions/runs/12261145292/job/34207472095 |
cc4154c
to
e7422b6
Compare
e7422b6
to
0ce2900
Compare
pass with monkey-patch https://github.com/nod-ai/shark-ai/actions/runs/12261289872/job/34207963383?pr=670 |
kuhar
reviewed
Dec 10, 2024
kuhar
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits. Thanks a lot for getting us unblocked.
12 tasks
IanNod
pushed a commit
to IanNod/SHARK-Platform
that referenced
this pull request
Dec 17, 2024
Hack/patch to workaround overlapping `AttrBuilder` registrations. Needed until iree-org/iree#19324 and llvm/llvm-project#117918 get resolved.
monorimet
pushed a commit
that referenced
this pull request
Jan 8, 2025
Hack/patch to workaround overlapping `AttrBuilder` registrations. Needed until iree-org/iree#19324 and llvm/llvm-project#117918 get resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack/patch to workaround overlapping
AttrBuilder
registrations. Needed until iree-org/iree#19324 and llvm/llvm-project#117918 get resolved.