Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enums] monkey patch register_attribute_builder #670

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 10, 2024

Hack/patch to workaround overlapping AttrBuilder registrations. Needed until iree-org/iree#19324 and llvm/llvm-project#117918 get resolved.

@makslevental makslevental force-pushed the makslevental/hack-register_attribute_builder branch 2 times, most recently from e268dfb to 5c9c80d Compare December 10, 2024 17:10
@makslevental makslevental changed the title [enums] hack/patch register_attribute_builder [enums] monkey patch register_attribute_builder Dec 10, 2024
@makslevental
Copy link
Contributor Author

@makslevental makslevental force-pushed the makslevental/hack-register_attribute_builder branch 2 times, most recently from cc4154c to e7422b6 Compare December 10, 2024 17:15
@makslevental makslevental force-pushed the makslevental/hack-register_attribute_builder branch from e7422b6 to 0ce2900 Compare December 10, 2024 17:17
@makslevental makslevental requested a review from kuhar December 10, 2024 17:17
@makslevental
Copy link
Contributor Author

makslevental commented Dec 10, 2024

@makslevental makslevental requested a review from kuhar December 10, 2024 17:26
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits. Thanks a lot for getting us unblocked.

@makslevental makslevental enabled auto-merge (squash) December 10, 2024 17:35
@makslevental makslevental merged commit 574861f into main Dec 10, 2024
9 checks passed
@makslevental makslevental deleted the makslevental/hack-register_attribute_builder branch December 10, 2024 17:36
IanNod pushed a commit to IanNod/SHARK-Platform that referenced this pull request Dec 17, 2024
Hack/patch to workaround overlapping `AttrBuilder` registrations. Needed
until iree-org/iree#19324 and
llvm/llvm-project#117918 get resolved.
monorimet pushed a commit that referenced this pull request Jan 8, 2025
Hack/patch to workaround overlapping `AttrBuilder` registrations. Needed
until iree-org/iree#19324 and
llvm/llvm-project#117918 get resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants